Fokko commented on code in PR #11955:
URL: https://github.com/apache/iceberg/pull/11955#discussion_r1913029561
##########
open-api/rest-catalog-open-api.py:
##########
@@ -132,11 +132,15 @@ class ExpressionType(BaseModel):
class TrueExpression(BaseModel):
- type: ExpressionType
+ type: ExpressionType = Field(
+ default_factory=lambda: ExpressionType.parse_obj('true'), const=True
+ )
Review Comment:
This still looks a bit odd, but I think we can refactor this by inlining the
`ExpressionType`, but I didn't want to do that in this PR. I think this is
better than before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
