xxchan commented on PR #849:
URL: https://github.com/apache/iceberg-rust/pull/849#issuecomment-2589822788
@Xuanwo I explored several ways to pin dependencies:
1. Modify `Cargo.lock` to get it work.
- Drawback: Need quite some manual work. And perhaps we need to disable
dependabot
- Benefit: guaranteed to work afterwards
2. Use `cargo generate-lockfile -Z minimal-versions`, but it doesn't work as
expected: e.g., `aws-sdk-glue` is specified as `1.39.0`, but it generated
`v1.71.0 (latest: v1.76.0)`, which is quite strange.
https://github.com/rust-lang/cargo/issues/5657#issuecomment-2278354432
3. Use `-Z direct-minimal-versions` as mentioned in the issue. It's indeed
works better,
- We need to manually specify the actual min versions in `Cargo.toml`.
But I guess it will also work afterwards.
- Another problem is some indirect dependencies' versions not constrained
and break MSRV. I found specifying `-Z direct-minimal-versions -Z
minimal-versions` can work..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
