ZENOTME commented on issue #891:
URL: https://github.com/apache/iceberg-rust/issues/891#issuecomment-2590004754
Thanks @hackintoshrao for pointing out this. I think the partition-specific
directory is not necessary to partition write?🤔 But it indeed reminds me to
think about how to support partition-specific directories. For now, our design
is hard to do this. We create the new file in parquet writer builder, but like
following case, the parquet writer builder is hard to know create a file under
which partition-specific directories. Only the data file writer know the file
corresponding to which partition.
```
let parquet_writer_builder = ParquetWriterBuilder::new(
WriterProperties::default(),
table.metadata().current_schema().clone(),
table.file_io().clone(),
location_generator.clone(),
file_name_generator.clone(),
);
```
According to
https://github.com/apache/iceberg/blob/3247964c88dbc95e1bbf4da8c39f9a5d9cf950fa/core/src/main/java/org/apache/iceberg/io/FileAppenderFactory.java#L41,
maybe we should redesign the FileWriterBuilder interface. I will try to send a
draft PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
