RussellSpitzer commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1915381785
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -364,15 +364,15 @@ public void testAddSnapshotToJson() throws IOException {
String manifestList = createManifestListWithManifestFiles(snapshotId,
parentId);
Snapshot snapshot =
- new BaseSnapshot(
- 0,
- snapshotId,
- parentId,
- System.currentTimeMillis(),
- DataOperations.REPLACE,
- ImmutableMap.of("files-added", "4", "files-deleted", "100"),
- schemaId,
- manifestList);
+ MetadataTestUtils.buildTestSnapshot()
Review Comment:
Do we need to specify as many things here any more? The default builder
should put all these values in correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
