HonahX commented on code in PR #11947:
URL: https://github.com/apache/iceberg/pull/11947#discussion_r1916012081
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -96,31 +97,47 @@ public class TestTableMetadata {
public TableOperations ops = new LocalTableOperations(temp);
- @Test
+ private static Stream<Integer> formatVersionsProvider() {
+ return Stream.of(1, 2, 3);
+ }
+
+ @ParameterizedTest
+ @MethodSource("formatVersionsProvider")
@SuppressWarnings("MethodLength")
- public void testJsonConversion() throws Exception {
+ public void testJsonConversion(int formatVersion) throws Exception {
Review Comment:
Yeah I should've paid more attention to this. It is actually just the last
sequence number need to be set to 0 for v1 metadata. I've updated the test to
remove the restriction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
