nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916272565
##########
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##########
@@ -43,7 +43,16 @@ public void testJsonConversion() throws IOException {
Snapshot expected =
new BaseSnapshot(
Review Comment:
I'm not convinced that builders in test code are the right path going
forward. For `BaseSnapshot` there's an easy way to avoid all the changes by
having an overriding constructor. We could most likely do the same for
TableMetadata, but let me first do a deep review of this PR to see what options
we have here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
