amogh-jahagirdar commented on code in PR #11986:
URL: https://github.com/apache/iceberg/pull/11986#discussion_r1919571061
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -721,9 +725,4 @@ public DeleteGranularity deleteGranularity() {
.defaultValue(DeleteGranularity.FILE)
.parse();
}
-
- public boolean useDVs() {
- TableOperations ops = ((HasTableOperations) table).operations();
- return ops.current().formatVersion() >= 3;
- }
Review Comment:
I ended up removing this since I realized it's not an officially released
public API on SparkWriteConf. We can just update deleteFileFormat() to return
PUFFIN and then use that in SparkPositionDeltaWrite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
