nastra commented on code in PR #12010:
URL: https://github.com/apache/iceberg/pull/12010#discussion_r1922279411
##########
api/src/main/java/org/apache/iceberg/UpdateStatistics.java:
##########
@@ -27,9 +27,19 @@ public interface UpdateStatistics extends
PendingUpdate<List<StatisticsFile>> {
* the snapshot if any exists.
*
* @return this for method chaining
+ * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0, use
setStatistics(statisticsFile).
*/
+ @Deprecated
UpdateStatistics setStatistics(long snapshotId, StatisticsFile
statisticsFile);
+ /**
+ * Set the table's statistics file for given snapshot, replacing the
previous statistics file for
+ * the snapshot if any exists.
+ *
+ * @return this for method chaining
+ */
+ UpdateStatistics setStatistics(StatisticsFile statisticsFile);
Review Comment:
This introduces a breaking API change, so we typically add a default impl
that throws:
```suggestion
default UpdateStatistics setStatistics(StatisticsFile statisticsFile) {
throw new UnsupportedOperationException("Setting statistics is not
supported");
}
```
Then you can remove the changes in `revapi.yml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
