Fokko commented on code in PR #1542:
URL: https://github.com/apache/iceberg-python/pull/1542#discussion_r1923485776
##########
pyiceberg/expressions/literals.py:
##########
@@ -145,6 +147,8 @@ def literal(value: L) -> Literal[L]:
return BinaryLiteral(value)
elif isinstance(value, Decimal):
return DecimalLiteral(value)
+ elif isinstance(value, datetime):
+ return TimestampLiteral(datetime_to_micros(value))
Review Comment:
The `tzinfo` is handled here:
https://github.com/apache/iceberg-python/blob/3981e620f4560e3d13bff3d062bd3a89e39971d0/pyiceberg/utils/datetime.py#L75-L81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
