aokolnychyi commented on code in PR #11675:
URL: https://github.com/apache/iceberg/pull/11675#discussion_r1924429613
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -224,34 +228,49 @@ public DataWriter<InternalRow> createWriter(int
partitionId, long taskId) {
.suffix("deletes")
.build();
- Schema positionDeleteRowSchema = positionDeleteRowSchema();
- StructType deleteSparkType = deleteSparkType();
- StructType deleteSparkTypeWithoutRow = deleteSparkTypeWithoutRow();
+ if (TableUtil.formatVersion(underlyingTable(table)) >= 3) {
Review Comment:
I think minor compaction for DVs would look quite different from the
existing logic. At the very least, we don't want to keep separate jobs per
partition. I'd say we should throw an exception right now if the action is
called on V3 tables until we figure out a good way to perform minor compaction
for DVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
