huaxingao commented on code in PR #11933:
URL: https://github.com/apache/iceberg/pull/11933#discussion_r1924604772
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -88,7 +85,7 @@ public final ColumnarBatch read(ColumnarBatch reuse, int
numRowsToRead) {
}
private class ColumnBatchLoader {
- private final int numRowsToRead;
+ private int numRowsToRead;
Review Comment:
Removed. Thanks
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java:
##########
@@ -106,27 +103,43 @@ private class ColumnBatchLoader {
}
ColumnarBatch loadDataToColumnBatch() {
- int numRowsUndeleted = initRowIdMapping();
-
ColumnVector[] arrowColumnVectors = readDataToColumnVectors();
+ if (!hasIsDeletedColumn) {
Review Comment:
Flipped. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
