aokolnychyi commented on code in PR #11825:
URL: https://github.com/apache/iceberg/pull/11825#discussion_r1924685635
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java:
##########
@@ -68,7 +70,8 @@ public void init(Map<String, String> options) {
@Override
protected Iterable<FileScanTask> filterFiles(Iterable<FileScanTask> tasks) {
- return Iterables.filter(tasks, task -> wronglySized(task) ||
tooManyDeletes(task));
+ return Iterables.filter(
+ tasks, task -> wronglySized(task) || tooManyDeletes(task) ||
tooHighDeleteRatio(task));
Review Comment:
What about adding `shouldRewrite` to match the code below?
```
private boolean shouldRewrite(FileScanTask task) {
return wronglySized(task) || tooManyDeletes(task) ||
tooHighDeleteRatio(task);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
