nastra commented on code in PR #11993:
URL: https://github.com/apache/iceberg/pull/11993#discussion_r1924900758
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -213,10 +213,13 @@ public void readFromViewUsingNonExistingTable() throws
NoSuchTableException {
assertThatThrownBy(() -> sql("SELECT * FROM %s", viewName))
.isInstanceOf(AnalysisException.class)
- .hasMessageContaining(
Review Comment:
I'd say let's keep the error messages for now until we actually see that
those become more difficult to maintain because they change more frequently
(which I actually don't expect to happen). The reason I'd like to keep the
error msg is to make sure that we properly ensure and see what a typical end
user would see when a certain error condition happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
