trim21 commented on code in PR #906:
URL: https://github.com/apache/iceberg-rust/pull/906#discussion_r1924944538


##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
   "Programming Language :: Python :: 3.12",
+  "Programming Language :: Python :: 3.13",
 ]
 
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"

Review Comment:
   you are not using poetry as package manager in this project but actually 
maturin so you should not add this. if you want to disallow `3.9.7` please add 
it to `project.requires-python`



##########
bindings/python/pyproject.toml:
##########
@@ -33,8 +33,12 @@ classifiers = [
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
   "Programming Language :: Python :: 3.12",
+  "Programming Language :: Python :: 3.13",
 ]
 
+[tool.poetry.dependencies]
+python = "^3.9, !=3.9.7"

Review Comment:
   you are not using poetry as package manager in this project but actually 
maturin so you should not add this.
   
   If you want to disallow `3.9.7` please add it to `project.requires-python`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to