nastra commented on code in PR #12025:
URL: https://github.com/apache/iceberg/pull/12025#discussion_r1925170994
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -314,8 +319,11 @@ public void testBackwardCompat() throws Exception {
assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull();
}
- @Test
- public void testInvalidMainBranch() throws IOException {
+ @ParameterizedTest
+ @FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")
Review Comment:
I'd suggest to do the same as mentioned in
https://github.com/apache/iceberg/pull/11948#discussion_r1916254927 and
parameterize this at the class level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
