rdblue commented on code in PR #12026:
URL: https://github.com/apache/iceberg/pull/12026#discussion_r1925667534
##########
orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java:
##########
@@ -326,13 +327,20 @@ private static TypeDescription buildOrcProjection(
orcType = originalType.clone();
}
} else {
+ Types.NestedField field = root.findField(fieldId);
if (isRequired) {
- throw new IllegalArgumentException(
+ Preconditions.checkArgument(
+ field.initialDefault() != null,
+ "Missing required field: %s (%s)",
Review Comment:
Yeah, I didn't realize I'd used the wrong name in the other PRs. I'll have
to go fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
