curtisr7 commented on code in PR #265:
URL: https://github.com/apache/iceberg-go/pull/265#discussion_r1925812970
##########
catalog/catalog.go:
##########
@@ -144,6 +150,7 @@ type options struct {
sigv4Service string
prefix string
authUri *url.URL
+ scope *string
Review Comment:
> Is there any particular benefit to differentiating that?
Likely not. I've pushed a commit to fix
##########
catalog/rest.go:
##########
@@ -491,11 +485,15 @@ func (r *RestCatalog) fetchAccessToken(cl *http.Client,
creds string, opts *opti
clientID, clientSecret = "", clientID
}
+ scope := "catalog"
+ if opts.scope != nil {
+ scope = *opts.scope
+ }
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
