rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1925927584
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java:
##########
@@ -35,17 +46,75 @@ public static ParquetValueWriter<Record>
buildWriter(MessageType type) {
@Override
protected StructWriter<Record>
createStructWriter(List<ParquetValueWriter<?>> writers) {
- return new RecordWriter(writers);
+ return ParquetValueWriters.recordWriter(writers);
}
- private static class RecordWriter extends StructWriter<Record> {
- private RecordWriter(List<ParquetValueWriter<?>> writers) {
- super(writers);
+ private static final OffsetDateTime EPOCH =
Instant.ofEpochSecond(0).atOffset(ZoneOffset.UTC);
+ private static final LocalDate EPOCH_DAY = EPOCH.toLocalDate();
+
+ protected static class DateWriter extends
ParquetValueWriters.PrimitiveWriter<LocalDate> {
Review Comment:
Similar, these should be package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
