rdblue commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1927632018
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetReaders.java:
##########
@@ -265,7 +263,7 @@ public ParquetValueReader<?> primitive(
case TIMESTAMP_MICROS:
return new UnboxedReader<>(desc);
case TIMESTAMP_MILLIS:
- return new TimestampMillisReader(desc);
+ return ParquetValueReaders.millisAsTimestamps(desc);
Review Comment:
This should also be `millisAsTimes`
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetReaders.java:
##########
@@ -265,7 +263,7 @@ public ParquetValueReader<?> primitive(
case TIMESTAMP_MICROS:
return new UnboxedReader<>(desc);
case TIMESTAMP_MILLIS:
- return new TimestampMillisReader(desc);
+ return ParquetValueReaders.millisAsTimestamps(desc);
Review Comment:
This should also be `millisAsTimes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
