kevinjqliu commented on code in PR #1568:
URL: https://github.com/apache/iceberg-python/pull/1568#discussion_r1929414445
##########
mkdocs/docs/configuration.md:
##########
@@ -116,6 +116,7 @@ For the FileIO there are several configuration options
available:
| s3.region | us-west-2 | Configure the default
region used to initialize an `S3FileSystem`. `PyArrowFileIO` attempts to
automatically resolve the region for each S3 bucket, falling back to this value
if resolution fails.
|
| s3.proxy-uri | <http://my.proxy.com:8080> | Configure the proxy
server to be used by the FileIO.
|
| s3.connect-timeout | 60.0 | Configure socket
connection timeout, in seconds.
|
+| s3.request-timeout | 60.0 | Configure socket read
timeouts on Windows and macOS, in seconds.
|
Review Comment:
i found `connect-timeout` which i think is different from `request-timeout`
https://github.com/apache/iceberg-go/blob/4b645d698fffaa99c235f54bf33f4340a4414bc5/io/s3.go#L47-L53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]