amogh-jahagirdar commented on code in PR #12102:
URL: https://github.com/apache/iceberg/pull/12102#discussion_r1929650157
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -67,8 +77,18 @@ protected ParquetValueReader<T> createReader(
}
}
+ /**
+ * @deprecated will be removed in 1.9.0; use {@link
#createStructReader(List, Types.StructType)}
+ * instead.
+ */
+ @Deprecated
+ protected ParquetValueReader<T> createStructReader(
+ List<Type> types, List<ParquetValueReader<?>> fieldReaders,
Types.StructType structType) {
+ return createStructReader(fieldReaders, structType);
+ }
+
protected abstract ParquetValueReader<T> createStructReader(
- List<Type> types, List<ParquetValueReader<?>> fieldReaders,
Types.StructType structType);
+ List<ParquetValueReader<?>> fieldReaders, Types.StructType structType);
Review Comment:
RevAPI is failing due to the new abstract method that implementations will
need to implement (which I understand the rationale, the previous types
argument were not used). I think we'll need to add the breaking change to revAPI
```
./gradlew :iceberg-parquet:revapiAcceptBreak --justification
"Implementations of ParquetValueReader.createStructReader should not have to
pass in explicit types" \
--code "java.method.abstractMethodAdded" \
--new "method org.apache.iceberg.parquet.ParquetValueReader<T>
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::createStructReader(java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>,
org.apache.iceberg.types.Types.StructType)"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
