ajantha-bhat commented on code in PR #12102:
URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933395608
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -214,10 +214,8 @@ public Optional<ParquetValueReader<?>> visit(
@Override
public Optional<ParquetValueReader<?>> visit(IntLogicalTypeAnnotation
intLogicalType) {
if (intLogicalType.getBitWidth() == 64) {
- if (intLogicalType.isSigned()) {
- // this will throw an UnsupportedOperationException
- return Optional.empty();
- }
+ Preconditions.checkArgument(
Review Comment:
I think we have lot of gaps in test coverage for parquet readers like
milli-time and timestamp reading, int96 reading, all kinds of signed, unsigned
reads. I will create a ticket to follow this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
