lliangyu-lin commented on code in PR #12132:
URL: https://github.com/apache/iceberg/pull/12132#discussion_r1934986266
##########
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##########
@@ -129,6 +130,81 @@ public void dropTableDataDeletesExpectedFiles() throws
IOException {
.containsAll(partitionStatsLocations);
}
+ @Test
Review Comment:
Thanks for the review!
Regarding the comment, I'm not sure if move to ```CatalogTests``` is really
necessary since there isn't any catalog specific logic in ```dropTableData```
##########
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##########
@@ -129,6 +130,81 @@ public void dropTableDataDeletesExpectedFiles() throws
IOException {
.containsAll(partitionStatsLocations);
}
+ @Test
+ public void dropTableDataDeletesAllPuffinFiles() throws IOException {
Review Comment:
Yes, I'll rename the test instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
