zizon commented on code in PR #12079:
URL: https://github.com/apache/iceberg/pull/12079#discussion_r1935008359
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -219,6 +228,191 @@ public void testTwoLevelList() throws IOException {
assertThat(recordRead.get("topbytes")).isEqualTo(expectedBinary);
}
+ @Test
+ public void testStreamClosedProperly() throws IOException {
+ // test for input
+ {
+ class TestStreamClosedProperlyStream extends SeekableInputStream
+ implements DelegatingInputStream {
+ boolean thisClosed = false;
+ boolean delegateClosed = false;
+
+ {
+ reset();
+ }
+
+ @Override
+ public InputStream getDelegate() {
+ return new FSDataInputStream(
+ new InputStream() {
Review Comment:
It depends on the scope of fixing.
Any subtype of `DelegateStream` which delegate to a `FSDataStream` can be
leaked in `ParquetIO::stream`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
