kevinjqliu commented on code in PR #11845:
URL: https://github.com/apache/iceberg/pull/11845#discussion_r1935822049
##########
docs/docs/spark-getting-started.md:
##########
@@ -39,22 +39,28 @@ spark-shell --packages
org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:{{ iceb
If you want to include Iceberg in your Spark installation, add the
[`iceberg-spark-runtime-3.5_2.12`
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.5_2.12/{{
icebergVersion }}/iceberg-spark-runtime-3.5_2.12-{{ icebergVersion }}.jar) to
Spark's `jars` folder.
-### Adding catalogs
+### Catalogs
-Iceberg comes with [catalogs](spark-configuration.md#catalogs) that enable SQL
commands to manage tables and load them by name. Catalogs are configured using
properties under `spark.sql.catalog.(catalog_name)`.
+Apache Iceberg uses [catalogs](https://iceberg.apache.org/concepts/catalog/)
to track and manage table metadata and enable SQL operations. Iceberg provides
several [catalog implementations](spark-configuration.md#catalogs), which can
be configured using properties under `spark.sql.catalog.(catalog_name)`.
-This command creates a path-based catalog named `local` for tables under
`$PWD/warehouse` and adds support for Iceberg tables to Spark's built-in
catalog:
+This command creates a JDBC-based catalog named `local` for tables under
`$PWD/warehouse` and adds support for Iceberg tables to Spark's built-in
catalog.
Review Comment:
maybe something like this,
```suggestion
This command creates a JDBC-based catalog named `local` for tables under
`$PWD/warehouse` and adds support for Iceberg tables to Spark's built-in
catalog (`spark_catalog`) using the Hive connector.
```
Is it the "Hive connector" or the "Hive Metastore"?
But I'm also incline not to add this. I feel like this is too detailed for a
"getting started" page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
