jbonofre commented on code in PR #12095:
URL: https://github.com/apache/iceberg/pull/12095#discussion_r1936944256
##########
spark/v3.5/spark-runtime/NOTICE:
##########
@@ -244,8 +372,63 @@ This binary artifact includes Apache Arrow with the
following in its NOTICE file
--------------------------------------------------------------------------------
-This binary artifact includes Netty buffers with the following in its NOTICE
-file:
+This binary artifact includes Apache Spark 3.5.4 with the following in its
NOTICE file:
Review Comment:
@rdblue is it not spark sql:
```
$ jar tvf iceberg-spark-runtime-3.5_2.12-1.8.0-SNAPSHOT.jar|grep -i spark
...
17709 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/CreateIcebergView.class
2628 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/DropIcebergView$.class
9049 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/DropIcebergView.class
2772 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/ResolvedV2View$.class
8309 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/ResolvedV2View.class
3667 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/ShowIcebergViews$.class
10910 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/catalyst/plans/logical/views/ShowIcebergViews.class
0 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/
3823 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AddPartitionFieldExec$.class
13747 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AddPartitionFieldExec.class
3550 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AlterV2ViewSetPropertiesExec$.class
12242 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AlterV2ViewSetPropertiesExec.class
3726 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AlterV2ViewUnsetPropertiesExec$.class
13921 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/AlterV2ViewUnsetPropertiesExec.class
3283 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CallExec$.class
9458 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CallExec.class
4164 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec$.class
16977 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.class
4107 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceTagExec$.class
16254 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceTagExec.class
5761 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec$.class
22816 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/CreateV2ViewExec.class
3118 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DescribeV2ViewExec$.class
16744 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DescribeV2ViewExec.class
3239 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropBranchExec$.class
11002 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropBranchExec.class
3376 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropIdentifierFieldsExec$.class
13778 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropIdentifierFieldsExec.class
3312 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropPartitionFieldExec$.class
12029 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropPartitionFieldExec.class
3206 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropTagExec$.class
10941 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropTagExec.class
3018 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropV2ViewExec$.class
9067 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/DropV2ViewExec.class
2214 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy$.class
2696 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy$IcebergCatalogAndIdentifier$.class
36410 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.class
3061 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/RenameV2ViewExec$.class
9166 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/RenameV2ViewExec.class
4245 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ReplacePartitionFieldExec$.class
15925 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ReplacePartitionFieldExec.class
3365 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/SetIdentifierFieldsExec$.class
11569 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/SetIdentifierFieldsExec.class
4147 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/SetWriteDistributionAndOrderingExec$.class
17208 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/SetWriteDistributionAndOrderingExec.class
2854 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec$.class
16975 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowCreateV2ViewExec.class
3184 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowV2ViewPropertiesExec$.class
14011 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowV2ViewPropertiesExec.class
3412 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowV2ViewsExec$.class
18726 Fri Feb 01 00:00:00 CET 1980
org/apache/spark/sql/execution/datasources/v2/ShowV2ViewsExec.class
```
It looks like Spark SQL here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
