dramaticlly commented on code in PR #12135:
URL: https://github.com/apache/iceberg/pull/12135#discussion_r1937711116
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -62,6 +67,44 @@
@ExtendWith(ParameterizedTestExtension.class)
public class TestMetadataTables extends ExtensionsTestBase {
+ @Parameter(index = 3)
+ private int formatVersion;
+
+ @Parameters(name = "catalogName = {0}, implementation = {1}, config = {2},
formatVersion = {3}")
+ protected static Object[][] parameters() {
Review Comment:
I think we can just add following lines to keep the original v2 coverage and
then selectively enable v3 for catalogs which are ready. Since many iceberg
users are still in the process of adopting REST based catalog and v2 is our
default spec at the moment, I think keep the current coverage in place to test
against metadata table change would be essential.
```java
{
SparkCatalogConfig.HIVE.catalogName(),
SparkCatalogConfig.HIVE.implementation(),
SparkCatalogConfig.HIVE.properties(),
2
},
{
SparkCatalogConfig.HADOOP.catalogName(),
SparkCatalogConfig.HADOOP.implementation(),
SparkCatalogConfig.HADOOP.properties(),
2
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
