amogh-jahagirdar commented on code in PR #12144: URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938393559
########## gcp-bundle/LICENSE: ########## @@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 - http://www.apache.org/licens Review Comment: Findbugs (com.google.code.findbugs) I see some contents from `META-INF` but no actual classes in the bundle bits ``` 0 Fri Feb 01 00:00:00 MST 1980 META-INF/maven/com.google.code.findbugs/ 0 Fri Feb 01 00:00:00 MST 1980 META-INF/maven/com.google.code.findbugs/jsr305/ 4286 Fri Feb 01 00:00:00 MST 1980 META-INF/maven/com.google.code.findbugs/jsr305/pom.xml 121 Fri Feb 01 00:00:00 MST 1980 META-INF/maven/com.google.code.findbugs/jsr305/pom.properties ``` I'd be +1 on excluding it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
