Fokko commented on code in PR #12161: URL: https://github.com/apache/iceberg/pull/12161#discussion_r1938946299
########## format/spec.md: ########## @@ -1400,7 +1400,7 @@ In some cases partition specs are stored using only the field list instead of th The `field-id` property was added for each partition field in v2. In v1, the reference implementation assigned field ids sequentially in each spec starting at 1,000. See Partition Evolution for more details. -In v3 metadata, writers must use only `source-ids` because v3 requires reader support for multi-arg transforms. In v1 and v2 metadata, writers must always write `source-id`; for multi-arg transforms, writers must produce `source-ids` and set `source-id` to the first ID from the field ID list. +In v3 metadata, writers must use only `source-ids` because v3 requires reader support for multi-arg transforms. Review Comment: You remember that correctly :) This PR doesn't touch the read-section: https://github.com/apache/iceberg/blob/f6faa58dac57e03be6e02a43937ac7c15c770225/format/spec.md?plain=1#L1562-L1565 For V3 the `source-id` should be omitted: https://github.com/apache/iceberg/blob/f6faa58dac57e03be6e02a43937ac7c15c770225/format/spec.md?plain=1#L1381 Let me know if you feel like more clarification is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
