rdblue commented on code in PR #12162:
URL: https://github.com/apache/iceberg/pull/12162#discussion_r1940256987
##########
format/spec.md:
##########
@@ -685,6 +686,8 @@ A snapshot consists of the following fields:
| _optional_ | _optional_ | _optional_ | **`schema-id`** | ID of
the table's current schema when the snapshot was created
|
| | | _optional_ | **`first-row-id`** | The
first `_row_id` assigned to the first row in the first data file in the first
manifest, see [Row Lineage](#row-lineage) |
| | | _optional_ | **`added-rows`** | Sum of
the [`added_rows_count`](#manifest-lists) from all manifests added in this
snapshot. Required if [Row Lineage](#row-lineage) is enabled |
+| | | _optional_ | **`encrypted-key-metadata`** |
Base64-encoded key metadata of the manifest list file in an encrypted table.
The key metadata is encrypted by a metadata encryption key before encoding |
+| | | _optional_ | **`key-metadata-key-id`** | The ID
of the encryption key that encrypts the manifest list key metadata
|
Review Comment:
After my chat with Russell, I think I would prefer to have all keys in table
metadata separate from snapshot. That leaves a lot of flexibility and only
requires adding a `key-id` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
