Fokko commented on code in PR #43:
URL: https://github.com/apache/iceberg-cpp/pull/43#discussion_r1940581911
##########
src/iceberg/schema_field.cc:
##########
@@ -52,8 +52,8 @@ const std::shared_ptr<Type>& SchemaField::type() const {
return type_; }
bool SchemaField::optional() const { return optional_; }
std::string SchemaField::ToString() const {
- return std::format("{} ({}): {}{}", name_, field_id_, *type_,
- optional_ ? "" : " (required)");
+ return std::format("{} ({}): {} {}", name_, field_id_, *type_,
+ optional_ ? "(optional)" : "(required)");
Review Comment:
```suggestion
return std::format("{} ({}): {} ({})", name_, field_id_, *type_,
optional_ ? "optional" : "required");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
