Fokko commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1941176126
########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -508,3 +466,63 @@ This binary artifact contains failsafe. Copyright: Jonathan Halterman and friends Home page: https://failsafe.dev/ License: https://www.apache.org/licenses/LICENSE-2.0.html + +-------------------------------------------------------------------------------- + +This binary artifact contains Codahale Metrics. Review Comment: Do we ship dropwizard itself: ``` libs git:(main) unzip iceberg-flink-runtime-1.20-1.8.0-SNAPSHOT.jar find . | grep -i dropwi ./org/apache/flink/dropwizard ./org/apache/flink/dropwizard/metrics ./org/apache/flink/dropwizard/metrics/DropwizardHistogramStatistics.class ./org/apache/flink/dropwizard/metrics/FlinkMeterWrapper.class ./org/apache/flink/dropwizard/metrics/FlinkHistogramWrapper.class ./org/apache/flink/dropwizard/metrics/FlinkCounterWrapper.class ./org/apache/flink/dropwizard/metrics/DropwizardHistogramWrapper.class ./org/apache/flink/dropwizard/metrics/HistogramStatisticsWrapper.class ./org/apache/flink/dropwizard/metrics/DropwizardMeterWrapper.class ./org/apache/flink/dropwizard/metrics/FlinkGaugeWrapper.class ./org/apache/flink/dropwizard/ScheduledDropwizardReporter.class ./org/apache/flink/dropwizard/ScheduledDropwizardReporter$1.class ./META-INF/maven/io.dropwizard.metrics ./META-INF/maven/io.dropwizard.metrics/metrics-core ./META-INF/maven/io.dropwizard.metrics/metrics-core/pom.xml ./META-INF/maven/io.dropwizard.metrics/metrics-core/pom.properties ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
