pvary commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941204512
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -93,6 +93,26 @@ public static TestTable create(
return new TestTable(ops, name, reporter);
}
+ public static TestTable create(
+ File temp,
+ String name,
+ Schema schema,
+ PartitionSpec spec,
+ int formatVersion,
+ Map<String, String> properties) {
Review Comment:
I think I don't really understand your answer here 😢
I'm not suggesting just simply adding the parameter.
What I'm suggesting is to create a new constructor with the extra parameter,
but in the old constructor we should remove the implementation and call the new
constructor with an empty property map. This way we will not have duplicated
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
