rdblue commented on code in PR #12139:
URL: https://github.com/apache/iceberg/pull/12139#discussion_r1941890941
##########
api/src/main/java/org/apache/iceberg/types/GetProjectedIds.java:
##########
@@ -47,7 +47,9 @@ public Set<Integer> struct(Types.StructType struct,
List<Set<Integer>> fieldResu
@Override
public Set<Integer> field(Types.NestedField field, Set<Integer> fieldResult)
{
- if ((includeStructIds && field.type().isStructType()) ||
field.type().isPrimitiveType()) {
+ if ((includeStructIds && field.type().isStructType())
+ || field.type().isPrimitiveType()
+ || field.type() instanceof Types.VariantType) {
Review Comment:
Yes, this new method is part of #11831
(https://github.com/apache/iceberg/pull/11831/files#diff-07bf8c52bb598ed9e1f2ad684e0afa646673cf380a24f286ea320e0dba039bbaR101)
from @aihuaxu. I just didn't want to add the same change here so I worked
around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
