mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2638039558
> late to the party, but i'll take a look too. Thanks for all the hard work here everyone!! Great @kevinjqliu . I think we are in good shape at this point. To bring you up to speed, here are the major changes we've worked through: - dropped support for datafusion dependency; i'm only using it in my test cases to generate test data, which I'm told is fine; all the compute is done via pyarrow filters - updates the unit tests to leverage pytest params - changed the name from "merge_rows" to "upsert" after some debate in a thread above - just some general efficiency stuff Thanks again everyone. I'm hoping this PR is now good to go! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
