pvary commented on code in PR #12191:
URL: https://github.com/apache/iceberg/pull/12191#discussion_r1946012368
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/SqlBase.java:
##########
@@ -86,7 +86,7 @@ protected void dropDatabase(String database, boolean
ifExists) {
sql("DROP DATABASE %s %s", ifExists ? "IF EXISTS" : "", database);
}
- protected static String toWithClause(Map<String, String> props) {
+ public static String toWithClause(Map<String, String> props) {
Review Comment:
Why is this change? Did this become a utility method which is shared between
tests? Can we find a better place for it then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
