mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2643139582
Hi @Fokko @tscottcoombes1 @kevinjqliu , Pushed one more (and I hope 😂) final round of updates; i fixed some formatting, replaced the SqlCatalog with the InMemory catalog for the test cases, and added some more commentary on why we are performing a second round of filtering for the rows_to_update to avoid unneccesary IO. Please review and let's get this over the finish line!!!! 🚀🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
