aokolnychyi commented on a change in pull request #1409:
URL: https://github.com/apache/iceberg/pull/1409#discussion_r483042851
##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -212,6 +183,114 @@ public String toString() {
protected abstract String defaultWarehouseLocation(TableIdentifier
tableIdentifier);
+ protected class BaseMetastoreCatalogTableBuilder implements TableBuilder {
+ private final TableIdentifier identifier;
+ private final Schema schema;
+ private final ImmutableMap.Builder<String, String> propertiesBuilder =
ImmutableMap.builder();
+ private PartitionSpec spec = PartitionSpec.unpartitioned();
+ private String location = null;
+
+ protected BaseMetastoreCatalogTableBuilder(TableIdentifier identifier,
Schema schema) {
+ Preconditions.checkArgument(isValidIdentifier(identifier), "Invalid
table identifier: %s", identifier);
Review comment:
We did not validate this for replace transactions before but there
should be no harm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
