hantangwangd opened a new pull request, #12201: URL: https://github.com/apache/iceberg/pull/12201
Currently, `TableScanUtil.adjustSplitSize(...)` can appropriately handle the situations where parameter `splitSize` is negative, however, it doesn't consider the situation where `splitSize` equals 0. That is to say, in a calculation engine like Spark, if we query a table after set it's property `read.split.target-size` to a negative value like `-1`, we will succeed and get the result, since the default `read.split.adaptive-size.enabled` is true. Meanwhile, if we query a table after set it's property `read.split.target-size` to 0, we will fail with the error message `/ by zero`. This PR fix the inappropriate handling of the 0 value of `splitSize`, ensure that both negative and zero values can be adjusted to appropriate split size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
