kaushiksrini commented on code in PR #1607:
URL: https://github.com/apache/iceberg-python/pull/1607#discussion_r1948228781
##########
pyiceberg/table/__init__.py:
##########
@@ -1179,6 +1182,11 @@ def refs(self) -> Dict[str, SnapshotRef]:
def _do_commit(self, updates: Tuple[TableUpdate, ...], requirements:
Tuple[TableRequirement, ...]) -> None:
response = self.catalog.commit_table(self, requirements, updates)
+
+ #
https://github.com/apache/iceberg/blob/f6faa58/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L527
+ # delete old metadata if METADATA_DELETE_AFTER_COMMIT_ENABLED is set
to true
+ self.catalog._delete_old_metadata(self.io, self.metadata,
response.metadata)
Review Comment:
added a try-catch, but the `deleteFiles` already has a warning for actually
deleting the files. I could only see an exception arise from
`_delete_old_metadata`'s operations.
https://github.com/apache/iceberg-python/blob/dd175aadfdf03df707bed37008f217258a916369/pyiceberg/catalog/__init__.py#L254-L269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
