manuzhang commented on code in PR #12120:
URL: https://github.com/apache/iceberg/pull/12120#discussion_r1952436339
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -377,7 +377,8 @@ private Builder doExecuteWithPartialProgress(
// stop commit service
commitService.close();
- int failedCommits = maxCommits - commitService.succeededCommits();
+ int totalCommits = groupsPerCommit == 1 ? ctx.totalGroupCount() :
maxCommits;
+ int failedCommits = totalCommits - commitService.succeededCommits();
Review Comment:
Because when a rewrite group fails, it's not submitted to commit service.
`failedCommits` only count failures in the commit service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
