smaheshwar-pltr commented on code in PR #1642: URL: https://github.com/apache/iceberg-python/pull/1642#discussion_r1956153130
########## mkdocs/docs/configuration.md: ########## @@ -203,12 +204,16 @@ PyIceberg uses [S3FileSystem](https://arrow.apache.org/docs/python/generated/pya ## Location Providers -Apache Iceberg uses the concept of a `LocationProvider` to manage file paths for a table's data. In PyIceberg, the +Apache Iceberg uses the concept of a `LocationProvider` to manage file paths for a table's data and metadata files. In PyIceberg, the `LocationProvider` module is designed to be pluggable, allowing customization for specific use cases. The `LocationProvider` for a table can be specified through table properties. -PyIceberg defaults to the [`ObjectStoreLocationProvider`](configuration.md#object-store-location-provider), which generates -file paths that are optimized for object storage. +Both data file and metadata file locations can be customized by configuring the table properties [write.data.path and write.metadata.path](#write-options), respectively. + +For more granular control, you can override the `LocationProvider`'s `new_data_location` and `new_metadata_location` methods to define custom logic for generating file paths. Review Comment: Nit: This only applies to custom location providers. *We* understand that and that they can be loaded but I think a new reader doesn't have that context at this point. How about appending something like " - see loading custom location providers" and linking `#loading-a-custom-location-provider` there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
