rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1958675667
##########
core/src/main/java/org/apache/iceberg/mapping/MappingUtil.java:
##########
@@ -302,6 +302,11 @@ public MappedFields map(Types.MapType map, MappedFields
keyResult, MappedFields
MappedField.of(map.valueId(), "value", valueResult));
}
+ @Override
+ public MappedFields variant(Types.VariantType variant) {
+ return null; // no mapping because variant no nested fields
Review Comment:
Minor: "no mapping because variant has no nested fields with IDs"
It is missing "has" (typo) and I think it is good to state that there are no
nested IDs because there can be nested data within a variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
