Fokko commented on code in PR #1669:
URL: https://github.com/apache/iceberg-python/pull/1669#discussion_r1959855449


##########
pyiceberg/table/__init__.py:
##########
@@ -1750,7 +1750,7 @@ def to_arrow_batch_reader(self) -> pa.RecordBatchReader:
         return pa.RecordBatchReader.from_batches(
             target_schema,
             batches,
-        )
+        ).cast(target_schema)

Review Comment:
   This will still return `large` types if you stream the batches because we 
don't want to fetch all the schemas upfront.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to