pvary commented on code in PR #12137:
URL: https://github.com/apache/iceberg/pull/12137#discussion_r1961802527
##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -96,7 +96,10 @@ private static PartitionMap<PartitionStats> collectStats(
StructLike key = keyTemplate.copyFor(coercedPartition);
Snapshot snapshot = table.snapshot(entry.snapshotId());
PartitionStats stats =
- statsMap.computeIfAbsent(specId, key, () -> new
PartitionStats(key, specId));
+ statsMap.computeIfAbsent(
+ specId,
+ ((PartitionData) file.partition()).copy(),
Review Comment:
Seems like the tests are broken by the infra 😢
Could you help me understand the original issue? I thought that I
understand, but seems like I still miss something.
I get that there is difference between the `partitionType` (which is the
unified spec), the `coercedPartition` which is the partition key for the
unified partition type.
What is the key we would like to see in the `statsMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
