bharos commented on code in PR #12327:
URL: https://github.com/apache/iceberg/pull/12327#discussion_r1962601041
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -265,55 +271,16 @@ public String description() {
return "AddFiles";
}
- private void validatePartitionSpec(Table table, Map<String, String>
partitionFilter) {
- List<PartitionField> partitionFields = table.spec().fields();
- Set<String> partitionNames =
-
table.spec().fields().stream().map(PartitionField::name).collect(Collectors.toSet());
-
- boolean tablePartitioned = !partitionFields.isEmpty();
- boolean partitionSpecPassed = !partitionFilter.isEmpty();
-
+ private void nonIdentityPartitionCheck(Table table) {
// Check for any non-identity partition columns
List<PartitionField> nonIdentityFields =
- partitionFields.stream()
+ table.spec().fields().stream()
Review Comment:
Using table.spec() here to determine nonIdentityFields as we want to see if
the table has any non-identity partitions until now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
