jonathanc-n commented on code in PR #960:
URL: https://github.com/apache/iceberg-rust/pull/960#discussion_r1964886069
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -391,6 +404,79 @@ impl ParquetWriter {
);
Ok(builder)
}
+
+ /// `ParquetMetadata` to data file builder
+ pub fn parquet_to_data_file_builder(
+ schema: SchemaRef,
+ metadata: Arc<ParquetMetaData>,
Review Comment:
I'm a bit confused here, to clarify the `FileMetadata` in `ParquetMetadata`
is different from the `FileMetadata`.
If I were to convert the ParquetMetadata to the filemetadata, I do not think
the conversion overhead is worth it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
