Fokko commented on code in PR #1703:
URL: https://github.com/apache/iceberg-python/pull/1703#discussion_r1966170554
##########
pyiceberg/table/__init__.py:
##########
@@ -1150,6 +1149,7 @@ def upsert(
Returns:
An UpsertResult class (contains details of rows updated and
inserted)
"""
+ from pyiceberg.io.pyarrow import expression_to_pyarrow
Review Comment:
Should we add this one here as well:
```suggestion
try:
import pyarrow as pa
except ModuleNotFoundError as e:
raise ModuleNotFoundError("For writes PyArrow needs to be
installed") from e
from pyiceberg.io.pyarrow import expression_to_pyarrow
```
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
