XBaith commented on code in PR #12366:
URL: https://github.com/apache/iceberg/pull/12366#discussion_r1967212427
##########
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##########
@@ -44,41 +46,85 @@
/** Factory to create a new {@link FileAppender} to write {@link Record}s. */
public class GenericAppenderFactory implements FileAppenderFactory<Record> {
-
+ private final Table table;
private final Schema schema;
private final PartitionSpec spec;
private final int[] equalityFieldIds;
private final Schema eqDeleteRowSchema;
private final Schema posDeleteRowSchema;
- private final Map<String, String> config = Maps.newHashMap();
+ private final Map<String, String> config;
+
+ private static final String WRITE_METRICS_PREFIX = "write.metadata.metrics.";
+ @Deprecated
public GenericAppenderFactory(Schema schema) {
- this(schema, PartitionSpec.unpartitioned(), null, null, null);
+ this(schema, PartitionSpec.unpartitioned());
}
+ @Deprecated
public GenericAppenderFactory(Schema schema, PartitionSpec spec) {
this(schema, spec, null, null, null);
}
+ @Deprecated
Review Comment:
Currently, creating `MetricConfig` directly from properties is marked as
deprecated, and in the future, it will be created using the `Table` instance.
Additionally, other implementations also use `Table` as a parameter in their
constructors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
