Fokko commented on code in PR #311:
URL: https://github.com/apache/iceberg-go/pull/311#discussion_r1971373579
##########
table/arrow_utils.go:
##########
@@ -497,7 +497,10 @@ func (c convertToArrow) Field(field iceberg.NestedField,
result arrow.Field) arr
func (c convertToArrow) List(list iceberg.ListType, elemResult arrow.Field)
arrow.Field {
elemField := c.Field(list.ElementField(), elemResult)
- return arrow.Field{Type: arrow.LargeListOfField(elemField)}
+ if c.useLargeTypes {
Review Comment:
I was pretty vocal on this one on the Python side. I strongly believe that
we should not expose the options of large types to the user, and that's the
[direction that we're
heading](https://github.com/apache/iceberg-python/pull/1669) with PyIceberg. In
the end, it is up to Arrow to decide if you need large types, or if small types
are sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
